Skip to content

Parallelize STREAM#148

Draft
str4d wants to merge 4 commits intomainfrom
parallel-stream
Draft

Parallelize STREAM#148
str4d wants to merge 4 commits intomainfrom
parallel-stream

Conversation

@str4d
Copy link
Copy Markdown
Owner

@str4d str4d commented Nov 4, 2020

Part of #271.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2020

Codecov Report

❌ Patch coverage is 63.96396% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.55%. Comparing base (456ce70) to head (4f72ab0).
⚠️ Report is 571 commits behind head on main.

Files with missing lines Patch % Lines
age/src/primitives/stream.rs 63.96% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   33.56%   34.55%   +0.99%     
==========================================
  Files          34       34              
  Lines        3081     3102      +21     
==========================================
+ Hits         1034     1072      +38     
+ Misses       2047     2030      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmillr
Copy link
Copy Markdown

Would be great to have this merged! Filippo doesn't seem to work on age much, so I think it's fine to make rage different in some regards.

Base automatically changed from master to main January 30, 2021 14:34
@str4d str4d force-pushed the parallel-stream branch from b81fbe2 to 6d8b2e2 Compare August 7, 2021 17:38
@tarcieri
Copy link
Copy Markdown

tarcieri commented Nov 8, 2021

Would love to have something like this upstream in the aead crate 😉

@str4d
Copy link
Copy Markdown
Owner Author

str4d commented Nov 8, 2021

The current issue with this PR is that it provides way too little performance improvement for the CPU cost it incurs. I still need to dig into this and figure out why.

@str4d str4d marked this pull request as draft March 7, 2023 18:11
@tengkuizdihar tengkuizdihar mentioned this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants