Skip to content

I3C Controller Library#2922

Closed
Aymane-ST wants to merge 2 commits intostm32duino:mainfrom
Aymane-ST:I3C_LIB
Closed

I3C Controller Library#2922
Aymane-ST wants to merge 2 commits intostm32duino:mainfrom
Aymane-ST:I3C_LIB

Conversation

@Aymane-ST
Copy link
Contributor

Depends on LPS22DF pr: Aymane-ST/LPS22DF#1

Tested on Nucleo H503RB and U385RG_Q

fpistm and others added 2 commits March 6, 2026 15:59
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
@Aymane-ST Aymane-ST requested review from cparata and fpistm March 6, 2026 15:43
@Aymane-ST Aymane-ST closed this Mar 6, 2026
Copy link
Contributor

@cparata cparata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Aymane,
regarding the example Entdaa, is it possible to implement it using the official LPS22DF library that you patched to add the I3C support? I think that the logic flow in this case should be:

I3C_BUS.begin();
I3C_BUS.rstdaa();
I3C_BUS.disec();
I3C_BUS.entdaa();
// 3) Identify the LPS22DF via WHO_AM_I
lps22df_instance.begin();

It is cleaner and perfectly aligned with the use case of the SETDASA and you don't need to use the helper files lps22df.cpp and lps22df.h. Maybe we can use a flag in the I3C constructor of the component to distinguish the use case where we use the SETDASA and the use case where we use the ENTDAA. So, we can eventually skip in the begin the SETDASA calls when we want to use the ENTDAA. I'm thinking that we can provide as optional in the LPS22DFClass I3C constructor the "staticAddr7" parameter; if it is not passed, we suppose that we are in the ENTDAA use case; if it is passed, we suppose that we are in the SETDASA use case.
What about this proposal? Is it feasible according to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants