Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
- Coverage 99.81% 99.69% -0.12%
==========================================
Files 109 109
Lines 2643 2648 +5
Branches 331 332 +1
==========================================
+ Hits 2638 2640 +2
- Misses 4 7 +3
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meoflynn
requested changes
Mar 24, 2026
Sometimes we need to add more than one User to a given Project with the
same Role. The current version of the st2 action only allows a single
User each time. In this change, we allow the possibility of multiple
Users at once.
Changes:
* user field in the YAML file for the web form:
* the variable for the username or user ID changed from type string to
type array
* description of the field changed accordingly
* python code
* name of the function to add an user changed from "role_add()" to
"role_add_single_user()"
* create a new function with the old name "role_add()" that only loops
over the list of users, calling the new function
"role_add_single_user()" for each one of them
jose-caballero
force-pushed
the
allow_more_than_one_user
branch
from
4c44d0b to
df22524
Compare
meoflynn
requested changes
Mar 24, 2026
Collaborator
meoflynn
left a comment
meoflynn
left a comment
There was a problem hiding this comment.
I think codecov is showing a missing test to show that role_add does call and runs the method for adding users from a list
anish-mudaraddi
approved these changes
Mar 24, 2026
Collaborator
anish-mudaraddi
left a comment
anish-mudaraddi
left a comment
There was a problem hiding this comment.
you're missing a test for your new function but its fine since we need this
meoflynn
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?