Open
Conversation
changelog: - use apt to install ansible rather than a virtualenv in vm_baseline - don't need to setup a venv for octavia install requirements - just install pip and use python that comes default in the container - there were some missing dependencies - so add that to the dockerfile - fix for setting locale in vm_baseline - refactor the entrypoint and move a few commands to the docker build file so we can speed up builds - allow setting custom output name
anish-mudaraddi
force-pushed
the
amphora-fixes
branch
from
0cf2878 to
9badf84
Compare
DavidFair
requested changes
Mar 23, 2026
This ensures we having working commits to rollback to, even if upstream introduces any breaking changes, plus we can see when the last working commit was
DavidFair
force-pushed
the
amphora-fixes
branch
from
c7fa667 to
7754fdb
Compare
DavidFair
approved these changes
Mar 24, 2026
Collaborator
DavidFair
left a comment
DavidFair
left a comment
There was a problem hiding this comment.
Approved for everything I didn't change
@anish-mudaraddi will check my commit to pin the SHA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog:
use apt to install ansible rather than a virtualenv in vm_baseline
don't need to setup a venv for octavia install
requirements - just install pip and use python that comes default in the container
there were some missing dependencies - so add that to the dockerfile
fix for setting locale in vm_baseline
refactor the entrypoint and move a few commands to the docker build file so we can speed up builds
allow setting custom output name