Merged
Conversation
part of the intervention period scheduled on 31st march. We are to migrate away from nginx ingress to envoy proxy on production
anish-mudaraddi
force-pushed
the
march-31st-intervention
branch
from
a8c2fbc to
4dc1f1a
Compare
Collaborator
Author
|
!! don't merge this until intervention !! |
azahmd
reviewed
Mar 27, 2026
| @@ -3,65 +3,7 @@ stfc-cloud-openstack-cluster: | |||
| cloudCredentialsSecretName: prod-management-cluster-cloud-credentials | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Do we need to add contolplane and nodegroups here?
azahmd
reviewed
Mar 27, 2026
Comment on lines
4
to
7
|
|
||
| nodeGroups: | ||
| - name: default-md-0 | ||
| machineCount: 5 |
Contributor
There was a problem hiding this comment.
Same - do we need to add controlplane and nodegroup defaults here?
jacob-ward
reviewed
Mar 30, 2026
| - name: envoy-gateways | ||
| chartName: envoy-gateways | ||
| namespace: envoy-gateway-system | ||
| valuesFile: ../../../clusters/prod/management/envoy-gateways-values.yaml |
Contributor
There was a problem hiding this comment.
Not a fan of relative pathing - suggest this should be altered in the future but happy to proceed for now
jacob-ward
reviewed
Mar 30, 2026
| ingressClassName: ingress-nginx-external No newline at end of file | ||
| clusterIssuers: | ||
| - name: external-le-staging | ||
| type: le-staging |
jacob-ward
approved these changes
Mar 30, 2026
azahmd
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
promotes charts and pushes changes to retire ingress nginx in favor of gateway api for prod clusters