Multiple keys for visibility of the same element#11
Open
Stacyy wants to merge 4 commits intostevenwanderski:masterfrom
Open
Multiple keys for visibility of the same element#11Stacyy wants to merge 4 commits intostevenwanderski:masterfrom
Stacyy wants to merge 4 commits intostevenwanderski:masterfrom
Conversation
added 4 commits
December 5, 2017 15:40
… visibility of the same elements
|
Hi @Stacyy, First of all, thanks for your work! I have reviewed your code. It works OK in the situation that there is only one element in the visilibity string. In the following case, the code does not handle the situation correctly: |
|
Hi @carlosreig - thanks for the review. I commissioned @Stacyy to add this feature, she's not currently working on my project for me to commission her to make the update so it may be a while until this gets updated (unless @Stacyy wants to fix this in her free time? 😝 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is allow defining multiple inputs which control the visibility for the same element.
@stevenwanderski please review the code.