SEP-0051: update JSON example.#1889
Merged
leighmcculloch merged 3 commits intostellar:masterfrom Mar 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SEP-0051 XDR-JSON TransactionEnvelope example to better reflect correct JSON field types/names for Soroban-era transactions.
Changes:
- Represent
seq_numas a JSON string (instead of a number) in the example. - Rename the example resource field
read_bytestodisk_read_bytes. - Represent
resource_feeas a JSON string (instead of a number) in the example.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated version to 2.0.1 and modified changelog.
leighmcculloch
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.