p25 cap cleaup #1876
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -82,9 +82,9 @@ | |||||
| | [CAP-0068](cap-0068.md) | 23 | Host function for getting executable for `Address` | Dmytro Kozhevin | Final | | ||||||
| | [CAP-0069](cap-0069.md) | 23 | String/Bytes conversion host functions | Dmytro Kozhevin | Final | | ||||||
| | [CAP-0070](cap-0070.md) | 23 | Configurable SCP Timing Parameters | Garand Tyson | Final | | ||||||
| | [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | | ||||||
|
Contributor
There was a problem hiding this comment. I had fixed this in #1880. Looks like its in master branch. Maybe you had a stale branch, @tomerweller ?
Contributor
There was a problem hiding this comment. ah, nevermind. This PR is old so we can close it since master has the fix. |
||||||
| | [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision | | ||||||
|
There was a problem hiding this comment. The protocol version for CAP-0075 should be 24, not 25. The CAP file (cap-0075.md line 13) specifies "Protocol version: 24".
Suggested change
|
||||||
| | [CAP-0076](cap-0076.md) | 24 | P23 State Archival bug remediation | Dmytro Kozhevin | Final | | ||||||
|
|
||||||
| ### Draft Proposals | ||||||
| | Number | Title | Author | Status | | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The protocol version for CAP-0074 should be 24, not 25. The CAP file (cap-0074.md line 13) specifies "Protocol version: 24".