Run "git submodule sync" during autogen.sh#5172
Merged
graydon merged 1 commit intostellar:masterfrom Mar 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo bootstrap process to avoid stale submodule URL configuration by running git submodule sync during autogen.sh, before initializing/updating submodules.
Changes:
- Run
git submodule syncwhen submodules are not skipped. - Keep existing submodule init/update and per-submodule
autogen.shinvocation flow unchanged.
leighmcculloch
previously approved these changes
Mar 11, 2026
leighmcculloch
approved these changes
Mar 16, 2026
Member
|
The quickstart build failing does not block this pull request, but fyi it is being fixed here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor thing but it bit me recently:
If you change one of the submodule URLs by editing .gitmodules, it doesn't immediately reflect in git's internal notion of submodule URLs -- git keeps a list of submodule URLs separate from .gitmodules and the two need to be "sync'ed" in order to reflect changes in .gitmodules. Goodness knows why, this just seems like a pointless git quirk, but it means that git keeps pulling from the wrong repo until you run "sync".