Conversation
Updated README
There was a problem hiding this comment.
Pull request overview
This pull request updates the README.md to replace specific production backend URLs with generic placeholder text for the INDEXER_URL and INDEXER_V2_URL environment variables.
Changes:
- Replaced concrete production backend URLs (
https://freighter-backend-prd.stellar.org/api/v1andhttps://freighter-backend-v2-prd.stellar.org/api/v1) with placeholder text (your_backend_v1_prod_url_hereandyour_backend_v2_prod_url_here)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| INDEXER_URL=your_backend_v1_prod_url_here | ||
| INDEXER_V2_URL=your_backend_v2_prod_url_here |
There was a problem hiding this comment.
The placeholder values "your_backend_v1_prod_url_here" and "your_backend_v2_prod_url_here" are inconsistent with line 53 which states "These URLs point to the production Freighter backend." If the intention is to provide placeholder values, the comment on line 53 should be updated to reflect that users need to fill in their own URLs. Additionally, this creates inconsistency with extension/README.md (line 15) which still provides the actual production URL: https://freighter-backend-prd.stellar.org/api/v1
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
|
@Keeeeeeeks This looks good, but I think you should implement Copilot's suggestion and change |
|
@copilot change |
|
@Keeeeeeeks I've opened a new pull request, #2578, to work on those changes. Once the pull request is ready, I'll request review from you. |
Updated README