Skip to content

Update README#2566

Open
Keeeeeeeks wants to merge 1 commit intomasterfrom
Keeeeeeeks-patch-1
Open

Update README#2566
Keeeeeeeks wants to merge 1 commit intomasterfrom
Keeeeeeeks-patch-1

Conversation

@Keeeeeeeks
Copy link
Contributor

Updated README

Updated README
Copilot AI review requested due to automatic review settings January 30, 2026 19:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the README.md to replace specific production backend URLs with generic placeholder text for the INDEXER_URL and INDEXER_V2_URL environment variables.

Changes:

  • Replaced concrete production backend URLs (https://freighter-backend-prd.stellar.org/api/v1 and https://freighter-backend-v2-prd.stellar.org/api/v1) with placeholder text (your_backend_v1_prod_url_here and your_backend_v2_prod_url_here)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +48 to +49
INDEXER_URL=your_backend_v1_prod_url_here
INDEXER_V2_URL=your_backend_v2_prod_url_here
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placeholder values "your_backend_v1_prod_url_here" and "your_backend_v2_prod_url_here" are inconsistent with line 53 which states "These URLs point to the production Freighter backend." If the intention is to provide placeholder values, the comment on line 53 should be updated to reflect that users need to fill in their own URLs. Additionally, this creates inconsistency with extension/README.md (line 15) which still provides the actual production URL: https://freighter-backend-prd.stellar.org/api/v1

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

@piyalbasu
Copy link
Contributor

@Keeeeeeeks This looks good, but I think you should implement Copilot's suggestion and change These URLs point to the production Freighter backend to something like These URLs point to your deployment of Freighter backend

@Keeeeeeeks
Copy link
Contributor Author

@copilot change These URLs point to the production Freighter backend to something like These URLs should point to your deployment of Freighter backend

Copy link
Contributor

Copilot AI commented Feb 6, 2026

@Keeeeeeeks I've opened a new pull request, #2578, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants