Open
Conversation
$(domTarget) wraps a D3 selection object rather than a DOM element, so
jQuery never correctly attached the resize listener. Use domTarget.node()
to extract the underlying DOM element. Switch both resize bindings from
the deprecated .resize(fn) shorthand to .on('resize', fn).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
$.type() was deprecated in jQuery 3.0 and removed in jQuery 4.0. The call site only needs a simple string primitive check, for which the native typeof operator is the direct equivalent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
$.isNumeric() was deprecated in jQuery 3.3 and removed in jQuery 4.0. At this call site ratio is a floating-point result of (hlen - offset) / hlen; the guard exists to catch NaN and Infinity when hlen is zero. Number.isFinite() is the exact native equivalent for that intent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades jQuery to 4.0.0 and makes necessary code changes, addressing #53.
Passes R CMD check and all the examples seem to be working correctly, apart from #62 (not sure if it is related).