Skip to content

CMD: Fix parsing of chk_flows_to_argument arguments #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sipma merged 1 commit into from
Mar 30, 2026
+3 −3
Merged

CMD: Fix parsing of chk_flows_to_argument arguments #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions chb/cmdline/reportcmds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,13 +1223,13 @@ def compare_function_attribute(attr: BCAttribute, instr: Instruction, pc: Librar
# Locate attribute corresponding to the library function being analyzed.
if attr.name == 'chk_flows_to_argument':
function_param = cast(BCAttrParamInt, attr.params[0]).intvalue
callsite_iaddr = cast(BCAttrParamInt, attr.params[1]).intvalue
callsite_tgt = cast(BCAttrParamCons, attr.params[2]).name
callsite_iaddr = cast(BCAttrParamStr, attr.params[1]).strvalue
callsite_tgt = cast(BCAttrParamStr, attr.params[2]).strvalue
callsite_param = cast(BCAttrParamInt, attr.params[3]).intvalue
access_type = cast(BCAttrParamCons, attr.params[4]).name
# Compare the annotation with the callsite address/target/parameter.
# Note: We add 1 to the index due to differing 0/1-indexing.
if callsite_iaddr == int(instr.iaddr, 16) and \
if callsite_iaddr == instr.iaddr and \
callsite_tgt == pc.summary.name and \
function_param == dstarg_index + 1 and \
access_type in ['read_write', 'write_only']:
Expand Down