Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR exposes sml::completion<T> as a first-class DSL event token, allowing it to be used directly in transition tables without wrapping it in event<...>. The implementation follows the same pattern as other internal event tokens like on_entry, on_exit, unexpected_event, and exception.
Changes:
- Modified
completionfrom a type alias to a variable template wrapped infront::event<back::completion<TEvent>> - Updated functional tests to use the simplified
completion<T>syntax instead ofevent<completion<T>>
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| include/boost/sml.hpp | Changed completion from type alias to variable template matching the pattern of other DSL event tokens (on_entry, on_exit, etc.) |
| test/ft/transitions.cpp | Updated test to use simplified completion<e1> syntax instead of event<completion<e1>> |
| test/ft/actions_process_n_defer.cpp | Updated tests to use simplified completion<T> syntax in multiple transition table definitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sml::completion<T>as a first-class DSL token so transitions can be written ascompletion<T>event<...>at call sitescompletion<T>usageTesting
./scripts/quality_gates.shcmake --build build --target test_transitions test_actions_process_n_defer -j8 && ./build/test/ft/test_transitions && ./build/test/ft/test_actions_process_n_defer