fix: remove double softplus on dt in non-fused Mamba2#845
fix: remove double softplus on dt in non-fused Mamba2#845Mr-Neutr0n wants to merge 1 commit intostate-spaces:mainfrom
Conversation
|
Sorry, can you describe the exact code path where the softplus is applied twice? It seems you're referring to the path starting line 158? Are you claiming the softplus is applied on line 162 and again on line 182 ( |
|
Suggest re-labeling as a refactor/cleanup rather than a bug fix and close the PR |
|
Yes, if you relabel this I can merge it |
Bug
In the non-fused/reference path of Mamba2Simple,
softplusis applied todttwice — once explicitly before passing to the SSM step, and once inside the step function. This over-smooths the timestep values.Fix
Removed the redundant softplus application to match the fused kernel behavior.