Add phash duration cutoff option#761
Open
InfiniteStash wants to merge 1 commit intostashapp:masterfrom
Open
Conversation
Contributor
|
Not sure what caused the mess in the example, but on FansDB side we have been dealing with very short durations (as short 1-2 seconds) and we haven't experienced anything like this (scale is close to 30k scenes). An alternative to this would be modifying the hash algorithm to better deal with lack of unique details, like proposed in stashapp/stash#4074. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phashes for short clips can cause issues because they generally don't contain enough details to uniquely identify a clip, which causes them to clump together along with associated md5/oshash fingerprints. An example is https://stashdb.org/scenes/e46fa5b8-7c3a-4db6-8522-17abeb26bfbb#fingerprints
I'm not sure what the best cutoff is, but at least 1-2mins I think, depending on content.