[vm1] disable module upgrade for vm1

[welbon]

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Summary by CodeRabbit

• Chores
  • Updated framework dependency to the latest version.

[coderabbitai]

Walkthrough

Updated the starcoin-framework dependency git revision in Cargo.toml from commit 6486837ca8b0578ed569a256a7605b1ad5735973 to e8f71bbdc3f72bf24fcbb29013c86c7857b8c634. No other dependencies or build configurations were modified.

Changes

Cohort / File(s)	Summary
Dependency Update Cargo.toml	Updated starcoin-framework git revision to a newer commit

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify the new revision contains only expected changes and no breaking updates
• Confirm no build or compilation issues arise from the updated dependency

Possibly related PRs

• fixed cargo dependency #4633: Previously updated the same starcoin-framework git revision in Cargo.toml; this PR advances it to a newer commit in the sequence.

Suggested reviewers

• sanlee42
• simonjiao

Poem

🐰 A nibble at the revision hash,
The framework gets a little dash,
From one commit to the next so bright,
Our bunny hops toward the light! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title claims to disable module upgrade for vm1, but the only change shown is a dependency version bump in Cargo.toml with no visible implementation of module upgrade disabling logic.	Either update the title to accurately reflect that this is a dependency update (e.g., 'Update starcoin-framework dependency'), or provide files showing the actual module upgrade disabling implementation.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bob/dual-verse-dag-disable-module-upgrade-1

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e6de8f2 and 9799c33.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

• Cargo.toml (1 hunks)

🧰 Additional context used

🧠 Learnings (7)

📓 Common learnings

Learnt from: welbon
Repo: starcoinorg/starcoin PR: 4655
File: cmd/starcoin/src/account/sign_multisig_txn_cmd.rs:61-63
Timestamp: 2025-09-13T14:15:32.756Z
Learning: In Starcoin codebase PR #4655 (Clap v3 to v4 upgrade), maintainer welbon confirmed the preference for minimal configuration changes during the upgrade, specifically declining suggestions to add num_args or value_delimiter attributes to maintain CLI compatibility with existing behavior, even when it might mean less optimal UX compared to new Clap v4 features.

Learnt from: welbon
Repo: starcoinorg/starcoin PR: 4633
File: vm/vm-runtime/Cargo.toml:48-48
Timestamp: 2025-09-01T03:56:58.362Z
Learning: In the Starcoin codebase, vm1 (starcoin-vm1-vm-runtime) may need to expose the same feature flags as vm2 to satisfy cross-version compatibility requirements when downstream projects like genesis depend on features from both versions. Empty feature declarations like `move-unit-test = []` may be intentionally added for compilation compatibility rather than to activate specific functionality.

Learnt from: welbon
Repo: starcoinorg/starcoin PR: 4655
File: cmd/resource-code-exporter/src/main.rs:42-44
Timestamp: 2025-09-13T14:13:05.713Z
Learning: In the Starcoin codebase Clap v3 to v4 upgrade (PR #4655), the maintainer welbon prefers minimal configuration changes to ensure compatibility, even if it means slight UX differences, rather than adding additional attributes like num_args or value_delimiter.

Learnt from: jackzhhuang
Repo: starcoinorg/starcoin PR: 4572
File: vm/types/src/block_metadata/mod.rs:47-48
Timestamp: 2025-07-03T03:21:32.104Z
Learning: In the starcoin repository, the BlockMetadata structure changes are part of a clean slate implementation with no legacy data that needs to be deserialized, so backward compatibility concerns for field type changes are not applicable.

📚 Learning: 2025-07-03T03:21:32.104Z

Learnt from: jackzhhuang
Repo: starcoinorg/starcoin PR: 4572
File: vm/types/src/block_metadata/mod.rs:47-48
Timestamp: 2025-07-03T03:21:32.104Z
Learning: In the starcoin repository, the BlockMetadata structure changes are part of a clean slate implementation with no legacy data that needs to be deserialized, so backward compatibility concerns for field type changes are not applicable.

Applied to files:

• Cargo.toml

📚 Learning: 2025-09-01T03:56:58.362Z

Learnt from: welbon
Repo: starcoinorg/starcoin PR: 4633
File: vm/vm-runtime/Cargo.toml:48-48
Timestamp: 2025-09-01T03:56:58.362Z
Learning: In the Starcoin codebase, vm1 (starcoin-vm1-vm-runtime) may need to expose the same feature flags as vm2 to satisfy cross-version compatibility requirements when downstream projects like genesis depend on features from both versions. Empty feature declarations like `move-unit-test = []` may be intentionally added for compilation compatibility rather than to activate specific functionality.

Applied to files:

• Cargo.toml

📚 Learning: 2025-09-13T14:15:32.756Z

Learnt from: welbon
Repo: starcoinorg/starcoin PR: 4655
File: cmd/starcoin/src/account/sign_multisig_txn_cmd.rs:61-63
Timestamp: 2025-09-13T14:15:32.756Z
Learning: In Starcoin codebase PR #4655 (Clap v3 to v4 upgrade), maintainer welbon confirmed the preference for minimal configuration changes during the upgrade, specifically declining suggestions to add num_args or value_delimiter attributes to maintain CLI compatibility with existing behavior, even when it might mean less optimal UX compared to new Clap v4 features.

Applied to files:

• Cargo.toml

📚 Learning: 2025-09-13T14:13:05.713Z

Learnt from: welbon
Repo: starcoinorg/starcoin PR: 4655
File: cmd/resource-code-exporter/src/main.rs:42-44
Timestamp: 2025-09-13T14:13:05.713Z
Learning: In the Starcoin codebase Clap v3 to v4 upgrade (PR #4655), the maintainer welbon prefers minimal configuration changes to ensure compatibility, even if it means slight UX differences, rather than adding additional attributes like num_args or value_delimiter.

Applied to files:

• Cargo.toml

📚 Learning: 2025-09-14T01:27:57.535Z

Learnt from: lushengguo
Repo: starcoinorg/starcoin PR: 4656
File: rpc/server/src/module/debug_rpc.rs:87-90
Timestamp: 2025-09-14T01:27:57.535Z
Learning: For debug/dev commands in the Starcoin codebase, the preference is to keep the implementation simple without excessive validation or access control checks, focusing on functionality rather than restrictive safeguards.

Applied to files:

• Cargo.toml

📚 Learning: 2025-09-16T01:30:06.195Z

Learnt from: lushengguo
Repo: starcoinorg/starcoin PR: 4658
File: vm2/vm-runtime/src/parallel_executor/mod.rs:0-0
Timestamp: 2025-09-16T01:30:06.195Z
Learning: In the Starcoin codebase, the Display schema for AccessPath is stable, making string-based matching via format!("{}", path) a reliable approach for identifying specific resource paths like the STC transaction fee aggregator.

Applied to files:

• Cargo.toml

🔇 Additional comments (1)

Cargo.toml (1)

530-530: Confirm external starcoin-framework revision implements the intended upgrade disable functionality.

The commit message confirms the PR objective: [vm1 disable upgrade]. The change is minimal and targeted—only Cargo.toml and Cargo.lock were modified, with no local source code changes. This aligns with the stated goal of disabling module upgrades for vm1 by pinning a specific starcoin-framework revision.

However, because the upgrade disable logic resides in the external starcoin-framework repository (not in local code), manual verification is needed: confirm that starcoin-framework revision e8f71bbdc3f72bf24fcbb29013c86c7857b8c634 actually implements the necessary changes to disable module upgrades for vm1, and verify there are no downstream impacts on other components that depend on starcoin-framework features.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}