Open
Conversation
9b7e5f1 to
a5d25d3
Compare
Member
|
Thank you for the pull request! I have added this feature to the lion development project. |
It's not RV64I yet, for it has no `*w` instructions (`addw` and such).
Author
|
@dopamane Now includes *W instructions; also generalized the SOC; PTAL and let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not RV64I yet, for it has no
*winstructions (addwand such).I'm not sure how complete you want it to be to consider it worth merging. I am working on the
*winstructions (shouldn't be too difficult; just involves design choices), but figure it might be clearer to review separately. Let me know.