Nodes manager registration only by cyc60 · Pull Request #700 · stakewise/v3-operator

cyc60 · 2026-03-25T09:49:21Z

No description provided.

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Signed-off-by: cyc60 <avsysoev60@gmail.com> # Conflicts: # src/common/abi/INodesManager.json # src/config/networks.py

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Copilot

Pull request overview

This PR expands the node manager “operator service” from eligibility polling into a full validator registration flow via oracles + NodesManager contract, and exposes deposit/funding amount helpers as public APIs.

Changes:

Promotes validator amount calculation helpers from private to public (get_deposits_amounts, get_funding_amounts) and updates callers/tests.
Implements NodesManager registration flow: build oracle approval requests, aggregate oracle signatures, and submit registerValidators tx.
Adds a new node_manager_start CLI with keystore/wallet configuration and introduces node_manager unit tests.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/validators/tasks.py	Renames internal helpers to public functions and updates internal usage.
src/validators/tests/test_tasks.py	Updates tests to call the new public helper names.
src/node_manager/typings.py	Adds request/approval dataclasses for oracle registration flow.
src/node_manager/oracles.py	Implements polling/aggregation of oracle approvals for registration.
src/node_manager/register_validators.py	Adds tx submission logic for NodesManager `registerValidators`.
src/node_manager/tasks.py	Extends task to register validators after eligibility + gas checks.
src/node_manager/startup_check.py	Renames parameter to `operator_address` for clarity.
src/commands/node_manager_start.py	Adds a CLI entrypoint and config wiring for the node manager service.
src/node_manager/tests/test_tasks.py	Adds unit tests for NodeManagerTask registration flow (with mocks).
src/node_manager/tests/test_register_validators.py	Adds unit tests for tx submission behavior and failure paths.
src/node_manager/tests/test_oracles.py	Adds unit tests for parsing and approval aggregation logic.
src/node_manager/tests/test_oracles_http.py	Adds HTTP tests for polling eligible operators and collecting approvals.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/node_manager/register_validators.py

src/node_manager/oracles.py

Copilot · 2026-03-25T10:01:24Z

src/node_manager/oracles.py

+    approvals_min_interval = 1
+    rate_limiter = RateLimiter(approvals_min_interval)
+
+    while True:
+        await rate_limiter.ensure_interval()
+


RateLimiter.ensure_interval() currently does asyncio.sleep(self.min_interval - elapsed) without clamping, which raises ValueError when the previous loop iteration took longer than min_interval (a common case here due to network I/O). Since this code relies on RateLimiter, await rate_limiter.ensure_interval() can crash poll_registration_approval. Consider avoiding RateLimiter here or adding a local clamp (sleep only when remaining > 0).

src/commands/node_manager_start.py

Signed-off-by: cyc60 <avsysoev60@gmail.com>

src/node_manager/oracles.py

evgeny-stakewise · 2026-03-25T19:09:12Z

src/node_manager/oracles.py

+
+def _parse_registration_response(data: dict) -> NodeManagerRegistrationApproval:
+    """Parse oracle response containing both keeper and NM signatures."""
+    keeper_params = data['keeperParams']


Suggested change

keeper_params = data['keeperParams']

keeper_params = data['keeper_params']

src/node_manager/tasks.py

src/node_manager/typings.py

src/node_manager/register_validators.py

src/node_manager/oracles.py

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/node_manager/tasks.py

src/node_manager/oracles.py

src/node_manager/tests/test_oracles.py

src/node_manager/typings.py

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

src/node_manager/oracles.py:1

poll_registration_approval loops indefinitely without any explicit cancellation/interrupt integration or adaptive backoff on repeated failures. This can block shutdowns (until task cancellation is handled elsewhere) and can continuously hammer oracles at a 1s interval during outages. Consider explicitly handling asyncio.CancelledError/stop conditions and adding a backoff strategy or a max retry window.

import asyncio

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/node_manager/tasks.py

Copilot · 2026-04-01T13:21:54Z

src/node_manager/oracles.py

+def _sign_deadline(deadline: int) -> HexStr:
+    """EIP-191 personal_sign of the deadline timestamp."""
+    message = encode_defunct(text=str(deadline))
+    return HexStr(wallet.sign_message(message).signature.hex())


The manager signature only covers deadline, which does not bind the signature to the specific approval request fields (operator, registry_root, validator_index, public_keys, amounts, etc.). This makes the signature replayable for arbitrary requests sharing the same deadline. Sign a deterministic payload that includes all security-relevant request fields (and ideally chain id / domain separation) so the oracles can verify the signature is for this exact request.

Copilot · 2026-04-01T13:21:54Z

src/node_manager/oracles.py

+
+    while True:
+        await rate_limiter.ensure_interval()
+
+        current_registry_root = await validators_registry_contract.get_registry_root()
+        if current_registry_root != validators_registry_root:
+            validators_registry_root = current_registry_root
+            oracles_request = None
+
+        current_timestamp = get_current_timestamp()
+        if oracles_request is None or deadline is None or deadline <= current_timestamp:
+            deadline = current_timestamp + protocol_config.signature_validity_period
+
+            oracles_request = await create_approval_request(
+                protocol_config=protocol_config,
+                keystore=keystore,
+                validators=validators,
+                registry_root=current_registry_root,
+                deadline=deadline,
+                operator_address=operator_address,
+            )
+
+        try:
+            raw_approvals = await send_registration_requests(protocol_config, oracles_request)
+            oracles_approval = process_registration_approvals(
+                raw_approvals, protocol_config.validators_threshold
+            )
+            return oracles_request, oracles_approval
+        except NotEnoughOracleApprovalsError as e:
+            logger.error(
+                'Not enough oracle approvals for community vault registration: %d.'
+                ' Threshold is %d.',
+                e.num_votes,
+                e.threshold,
+            )
+        except InvalidOraclesRequestError:
+            logger.error('All oracles failed to respond for community vault registration')


poll_registration_approval loops indefinitely without any explicit cancellation/interrupt integration or adaptive backoff on repeated failures. This can block shutdowns (until task cancellation is handled elsewhere) and can continuously hammer oracles at a 1s interval during outages. Consider explicitly handling asyncio.CancelledError/stop conditions and adding a backoff strategy or a max retry window.

Suggested change

while True:

await rate_limiter.ensure_interval()

current_registry_root = await validators_registry_contract.get_registry_root()

if current_registry_root != validators_registry_root:

validators_registry_root = current_registry_root

oracles_request = None

current_timestamp = get_current_timestamp()

if oracles_request is None or deadline is None or deadline <= current_timestamp:

deadline = current_timestamp + protocol_config.signature_validity_period

oracles_request = await create_approval_request(

protocol_config=protocol_config,

keystore=keystore,

validators=validators,

registry_root=current_registry_root,

deadline=deadline,

operator_address=operator_address,

)

try:

raw_approvals = await send_registration_requests(protocol_config, oracles_request)

oracles_approval = process_registration_approvals(

raw_approvals, protocol_config.validators_threshold

)

return oracles_request, oracles_approval

except NotEnoughOracleApprovalsError as e:

logger.error(

'Not enough oracle approvals for community vault registration: %d.'

' Threshold is %d.',

e.num_votes,

e.threshold,

)

except InvalidOraclesRequestError:

logger.error('All oracles failed to respond for community vault registration')

failure_count = 0

try:

while True:

await rate_limiter.ensure_interval()

current_registry_root = await validators_registry_contract.get_registry_root()

if current_registry_root != validators_registry_root:

validators_registry_root = current_registry_root

oracles_request = None

current_timestamp = get_current_timestamp()

if oracles_request is None or deadline is None or deadline <= current_timestamp:

deadline = current_timestamp + protocol_config.signature_validity_period

oracles_request = await create_approval_request(

protocol_config=protocol_config,

keystore=keystore,

validators=validators,

registry_root=current_registry_root,

deadline=deadline,

operator_address=operator_address,

)

try:

raw_approvals = await send_registration_requests(protocol_config, oracles_request)

oracles_approval = process_registration_approvals(

raw_approvals, protocol_config.validators_threshold

)

# Reset failure counter on success

failure_count = 0

return oracles_request, oracles_approval

except NotEnoughOracleApprovalsError as e:

failure_count += 1

logger.error(

'Not enough oracle approvals for community vault registration: %d.'

' Threshold is %d.',

e.num_votes,

e.threshold,

)

except InvalidOraclesRequestError:

failure_count += 1

logger.error('All oracles failed to respond for community vault registration')

# Apply exponential backoff on repeated failures, capped to 60 seconds

backoff_delay = min(approvals_min_interval * (2 ** min(failure_count, 5)), 60)

logger.debug(

'Backing off for %s seconds before retrying registration approval polling',

backoff_delay,

)

await asyncio.sleep(backoff_delay)

except asyncio.CancelledError:

logger.info('Registration approval polling cancelled')

raise

src/node_manager/oracles.py

Copilot · 2026-04-01T13:21:55Z

src/commands/node_manager_start.py

+    envvar='MAX_VALIDATOR_BALANCE_GWEI',
+    help=f'The maximum validator balance in Gwei. '
+    f'Default is {NETWORKS[MAINNET].MAX_VALIDATOR_BALANCE_GWEI} Gwei',
+    callback=validate_max_validator_balance_gwei,


The CLI help states a default value, but the option does not set a Click default=..., so max_validator_balance_gwei will be None when omitted. If settings.configure(...) applies None literally, this can override the intended network default and break V2 deposit splitting. Set an explicit Click default (preferably derived from the selected network), or avoid passing the field to settings.configure when the option is unset.

Suggested change

envvar='MAX_VALIDATOR_BALANCE_GWEI',

help=f'The maximum validator balance in Gwei. '

f'Default is {NETWORKS[MAINNET].MAX_VALIDATOR_BALANCE_GWEI} Gwei',

callback=validate_max_validator_balance_gwei,

envvar='MAX_VALIDATOR_BALANCE_GWEI',

default=NETWORKS[MAINNET].MAX_VALIDATOR_BALANCE_GWEI,

help=f'The maximum validator balance in Gwei. '

f'Default is {NETWORKS[MAINNET].MAX_VALIDATOR_BALANCE_GWEI} Gwei',

callback=validate_max_validator_balance_gwei,

show_default=True,

Copilot · 2026-04-01T13:21:55Z

src/commands/node_manager_start.py

+        max_validator_balance_gwei=(
+            Gwei(max_validator_balance_gwei) if max_validator_balance_gwei else None
+        ),


The CLI help states a default value, but the option does not set a Click default=..., so max_validator_balance_gwei will be None when omitted. If settings.configure(...) applies None literally, this can override the intended network default and break V2 deposit splitting. Set an explicit Click default (preferably derived from the selected network), or avoid passing the field to settings.configure when the option is unset.

src/node_manager/tasks.py

Signed-off-by: cyc60 <avsysoev60@gmail.com>

src/node_manager/tests/test_oracles_http.py

src/node_manager/tests/test_oracles.py

evgeny-stakewise · 2026-04-02T12:56:25Z

src/node_manager/oracles.py

+
+def _parse_registration_response(data: dict) -> NodeManagerRegistrationApproval:
+    """Parse oracle response containing both keeper and NM signatures."""
+    keeper_params = data['keeperParams']


src/node_manager/oracles.py

src/node_manager/typings.py

src/node_manager/tests/test_tasks.py

src/node_manager/tests/test_oracles_http.py

Signed-off-by: cyc60 <avsysoev60@gmail.com>

evgeny-stakewise · 2026-04-02T14:46:55Z

src/node_manager/oracles.py

+
+
+def _parse_registration_response(data: dict) -> NodeManagerRegistrationApproval:
+    """Parse oracle response containing both keeper and NM signatures."""


Replace NM to Nodes Manager in docstrings

cyc60 added 11 commits March 11, 2026 13:56

Merge branch 'v5-release' into node-manager

f071df3

Add validators registrations\funding

0d9cc6f

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Merge branch 'node-manager' into nm-registration

a891e0b

Update api scheme

bf3bab8

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Add tests

0472644

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Merge branch 'node-manager' into nm-registration

c25973a

Signed-off-by: cyc60 <avsysoev60@gmail.com> # Conflicts: # src/common/abi/INodesManager.json # src/config/networks.py

Merge branch 'node-manager' into nm-registration

39ae716

Fix tests

9b73270

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Fix contract call

f62ca6f

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Rename to operator_address

967cb2c

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Rm funding

722eef0

Signed-off-by: cyc60 <avsysoev60@gmail.com>

cyc60 requested a review from Copilot March 25, 2026 09:54

Copilot started reviewing on behalf of cyc60 March 25, 2026 09:54 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

cyc60 added 2 commits March 25, 2026 14:01

Copilot fixes

1461a46

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Handle InvalidOraclesRequestError

55e73e2

Signed-off-by: cyc60 <avsysoev60@gmail.com>

evgeny-stakewise reviewed Mar 27, 2026

View reviewed changes

src/node_manager/register_validators.py Outdated Show resolved Hide resolved

evgeny-stakewise reviewed Mar 30, 2026

View reviewed changes

src/node_manager/oracles.py Outdated Show resolved Hide resolved

cyc60 added 2 commits March 30, 2026 21:59

Review fixes

df0c168

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Use HexStr for signatures

bddd47a

Signed-off-by: cyc60 <avsysoev60@gmail.com>

cyc60 requested a review from Copilot March 31, 2026 07:16

Rename to validators_manager_signature

0abf534

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Copilot started reviewing on behalf of cyc60 March 31, 2026 07:17 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

src/node_manager/tasks.py Show resolved Hide resolved

src/node_manager/tasks.py Show resolved Hide resolved

src/node_manager/tasks.py Outdated Show resolved Hide resolved

src/node_manager/tasks.py Outdated Show resolved Hide resolved

evgeny-stakewise reviewed Mar 31, 2026

View reviewed changes

src/node_manager/oracles.py Outdated Show resolved Hide resolved

src/node_manager/tests/test_oracles.py Outdated Show resolved Hide resolved

src/node_manager/typings.py Outdated Show resolved Hide resolved

evgeny-stakewise changed the title ~~Nm registration only~~ Nodes manager registration only Mar 31, 2026

cyc60 added 3 commits April 1, 2026 14:28

Refactor tests

d8ffd65

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Rename to nodes_manager_signature

e8dc553

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Use disable_validators_registration settings

d7db0a5

Signed-off-by: cyc60 <avsysoev60@gmail.com>

cyc60 requested a review from Copilot April 1, 2026 13:14

Copilot AI reviewed Apr 1, 2026

View reviewed changes

cyc60 added 2 commits April 1, 2026 22:38

Pass protocol_config

c4c4cb2

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Improve tests

00dad4e

Signed-off-by: cyc60 <avsysoev60@gmail.com>

evgeny-stakewise reviewed Apr 2, 2026

View reviewed changes

Review fixes

90440b7

Signed-off-by: cyc60 <avsysoev60@gmail.com>

evgeny-stakewise reviewed Apr 2, 2026

View reviewed changes

	keeper_params = data['keeperParams']
	keeper_params = data['keeper_params']



		def _parse_registration_response(data: dict) -> NodeManagerRegistrationApproval:
		"""Parse oracle response containing both keeper and NM signatures."""

Conversation

cyc60 commented Mar 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

evgeny-stakewise Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

evgeny-stakewise Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

evgeny-stakewise Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

evgeny-stakewise Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants