Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates the latest changes from the base branch, focusing on wallet connector updates and infrastructure improvements. Key changes include wallet rebrands (XDEFI → CTRL, Argent → Ready), new wallet integrations, dependency upgrades, and enhanced testing infrastructure.
Key Changes
- Wallet Ecosystem Updates: Rebranded XDEFI to CTRL wallet, Argent to Ready wallet, replaced Coinbase Wallet with Base Account in default wallet list
- New Wallet Integrations: Added Nova, Porto, Gemini, Universal Profiles wallets with proper connector implementations
- Infrastructure Improvements: Added comprehensive test infrastructure with MSW for WalletConnect mocking, upgraded wagmi to ^2.19 and viem to 2.38.0, improved pnpm workspace configuration
Reviewed Changes
Copilot reviewed 56 out of 68 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Enhanced workspace configuration with package age restrictions |
| packages/rainbowkit/test/mockWalletConnect.ts | New WalletConnect testing utilities with MSW server setup |
| packages/rainbowkit/test/mockRainbow.ts | Rainbow wallet mock utilities for EIP-1193/6963 testing |
| packages/rainbowkit/src/wallets/walletConnectors/ctrlWallet/ctrlWallet.ts | New CTRL wallet connector replacing deprecated XDEFI |
| packages/rainbowkit/src/wallets/walletConnectors/baseAccount/baseAccount.ts | New Base Account connector replacing Coinbase Wallet |
| packages/rainbowkit/src/wallets/walletConnectors/argentWallet/argentWallet.ts | Deprecated Argent, now delegates to Ready wallet |
| packages/rainbowkit/src/wallets/walletConnectors/[various]/[wallet].ts | Fixed mobile visibility by conditionally setting installed property |
| packages/rainbowkit/src/components/ConnectOptions/DesktopOptions.tsx | Renamed WalletStep.None to SelectWallet for clarity |
| packages/rainbowkit/src/components/ConnectModal/ConnectFlow.test.tsx | Comprehensive integration tests for wallet connection flows |
| packages/rainbowkit/src/wallets/useWalletConnectors.ts | Enhanced connect function to support parameters and proper typing |
| packages/rainbowkit/src/locales/en_US.json | Updated localization for renamed/new wallets |
| package.json | Upgraded dependencies (wagmi ^2.19.3, viem 2.38.0, pnpm 10.21.0) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/rainbowkit/src/wallets/walletConnectors/ctrlWallet/ctrlWallet.ts
Show resolved
Hide resolved
packages/rainbowkit/src/wallets/walletConnectors/baseAccount/baseAccount.ts
Show resolved
Hide resolved
packages/rainbowkit/src/wallets/walletConnectors/coin98Wallet/coin98Wallet.ts
Show resolved
Hide resolved
packages/rainbowkit/src/wallets/walletConnectors/binanceWallet/binanceWallet.ts
Show resolved
Hide resolved
packages/rainbowkit/src/wallets/walletConnectors/novaWallet/novaWallet.ts
Show resolved
Hide resolved
Philippoes
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.