Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces several schema changes and new API endpoints for reporting daily revenues and performance. Key changes include adding new yield providers and networks, introducing additional transaction types and schema interfaces, and updating API query functions and their corresponding MSW mocks.
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/api-hooks/src/api/schemas/yieldV2YieldsProviderId.ts | Added new yield providers ("blend", "synthetix") |
| packages/api-hooks/src/api/schemas/yieldV2YieldsNetwork.ts | Added new network entries ("ethereum-hoodi", "stellar", "stellar-testnet") |
| packages/api-hooks/src/api/schemas/yieldProviders.ts | Added new yield provider entries similar to yieldV2 changes |
| packages/api-hooks/src/api/schemas/walletViewDto.ts, unauthorizedDto.ts, stakeResponseDto*.ts, serverErrorDto.ts | Introduced new schema interfaces and types |
| packages/api-hooks/src/api/schemas/reportProject* | Defined new types and interfaces for reporting daily revenues and performance |
| packages/api-hooks/src/api/index.ts & index.msw.ts | Added new API endpoints and updated mock handlers for reporting functionality |
| packages/api-hooks/package.json & .vscode/settings.json | Updated package version and editor settings |
Comments suppressed due to low confidence (1)
packages/api-hooks/src/api/schemas/argumentOptionsDto.ts:13
- [nitpick] Consider adding a documentation comment for the new 'providerId' property to maintain consistency with the other documented properties.
providerId?: RequiredArgumentWithOptionsDto;
| limit: faker.number.int({ min: undefined, max: undefined }), | ||
| page: faker.number.int({ min: undefined, max: undefined }), | ||
| ...overrideResponse, | ||
| ...overrideResponse, |
There was a problem hiding this comment.
Duplicate spreading of overrideResponse is present. Please remove one instance unless intentionally merging multiple override objects.
Suggested change
| ...overrideResponse, |
Philippoes
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Description of new functionality, feature, or content that has been added in this pull request.
Changed
Description of the modifications made to existing functionality, feature, or content in this pull request. This could include changes to code, CI, documentation, etc.