feat(stoprecord): early stop access for rcon admins#11
Merged
Rushaway merged 3 commits intosrcdslab:masterfrom Sep 22, 2025
Merged
feat(stoprecord): early stop access for rcon admins#11Rushaway merged 3 commits intosrcdslab:masterfrom
Rushaway merged 3 commits intosrcdslab:masterfrom
Conversation
- Updated the permissions for the sm_stoprecord command to require ADMFLAG_RCON. -Made various formatting improvements for consistency.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the AutoRecorder plugin by changing the permission requirements for the stop recording command and provides different behavior based on admin privileges. The main purpose is to allow RCON admins to stop recordings while implementing a more graceful shutdown process for them.
- Updated
sm_stoprecordcommand permissions fromADMFLAG_ROOTtoADMFLAG_RCON - Added conditional logic that provides RCON admins with a "stop at round end" option instead of immediate termination
- Incremented the patch version from 1.4.2 to 1.4.3
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| AutoRecorder.inc | Version bump to reflect the new functionality |
| AutoRecorder.sp | Permission change and conditional stop behavior implementation |
Add option for immediate stop of SourceTV recording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Made various formatting improvements for consistency.