Skip to content

Add WorkflowTestParams overloads to launchForTestingFromStateWith#1489

Merged
steve-the-edwards merged 2 commits intomainfrom
sedwards/testparams-launchfortesting-overloads
Mar 19, 2026
Merged

Add WorkflowTestParams overloads to launchForTestingFromStateWith#1489
steve-the-edwards merged 2 commits intomainfrom
sedwards/testparams-launchfortesting-overloads

Conversation

@steve-the-edwards
Copy link
Copy Markdown
Contributor

@steve-the-edwards steve-the-edwards commented Mar 18, 2026

Summary

  • add testParams overloads for both deprecated launchForTestingFromStateWith entry points
  • preserve existing overloads and delegate them through the new signatures for backward compatibility
  • add unit coverage proving both overloads honor testParams
  • update workflow-testing.api for the new public overloads

Testing

  • ./gradlew :workflow-testing:test --tests com.squareup.workflow1.testing.WorkflowTestRuntimeTest
  • ./gradlew :workflow-testing:apiDump
  • ./gradlew :workflow-testing:apiCheck

@steve-the-edwards steve-the-edwards marked this pull request as ready for review March 18, 2026 20:45
@steve-the-edwards steve-the-edwards force-pushed the sedwards/testparams-launchfortesting-overloads branch from 3d2c318 to 5367a81 Compare March 18, 2026 20:50
@steve-the-edwards steve-the-edwards requested a review from a team as a code owner March 18, 2026 20:50
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@steve-the-edwards steve-the-edwards changed the base branch from release-v1.25.4 to main March 19, 2026 13:22
@steve-the-edwards steve-the-edwards merged commit 8ec0b3f into main Mar 19, 2026
73 checks passed
@steve-the-edwards steve-the-edwards deleted the sedwards/testparams-launchfortesting-overloads branch March 19, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants