Conversation
fix: create local secrets with o+rw feat: after failed anon access, prompt for key fix: if we should prompt OR it's a push, prompt
…to pull when push
fix: create local secrets with o+rw feat: after failed anon access, prompt for key fix: if we should prompt OR it's a push, prompt
fix: create local secrets with o+rw feat: after failed anon access, prompt for key fix: if we should prompt OR it's a push, prompt
…to pull when push
feat: Push subscription and conflict detection. Conflict detection is behind a flag and disabled at compile time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements for automated synchronization and conflict handling in the SQLite rsync client, along with initial groundwork for future diff and merge capabilities. The most important changes are grouped below.
Automated Sync & Subscription Improvements
waitIdle,maxInterval,minInterval,merge) to support long-running automated PUSH and PULL operations, enabling more flexible and user-friendly subscription workflows inclient/main.go. [1] [2]Duration Parsing & Validation
sync.ParseDurationandsync.ValidateWaitIdleto robustly parse and validate time intervals for automated sync triggers, supporting units up to weeks and enforcing sensible bounds.Remote Client Protocol Enhancements
SQLRSYNC_CHANGED) and tracking version conflicts, key types, and latest commit versions inclient/remote/client.go, laying groundwork for future conflict detection and resolution. [1] [2] [3] [4] [5]Interactive Key Handling
Foundation for SQLite Diff/Merge
bridge/cgo_sqldiff.go,bridge/sqldiff_wrapper.c,bridge/sqldiff_wrapper.h), providing an API to compare databases and detect conflicts, with placeholder implementation pending integration of fullsqldiff.c. [1] [2] [3]These changes collectively advance the client toward robust, automated, and conflict-aware synchronization, while preparing for future merge and diff features.