Update rspec syntax to use 'expect' and also change '==' to 'eq' and '=~' to 'match'#246
Open
durrantm wants to merge 1 commit intosporkrb:masterfrom
durrantm:rspec_expect_syntax
Open
Update rspec syntax to use 'expect' and also change '==' to 'eq' and '=~' to 'match'#246durrantm wants to merge 1 commit intosporkrb:masterfrom durrantm:rspec_expect_syntax
durrantm wants to merge 1 commit intosporkrb:masterfrom
durrantm:rspec_expect_syntax
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated specs to use expect syntax.
As you may well know, using 'expect' over 'should' is a recommended practice because of dealing with delegate/proxy objects as detailed in http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax.
As detailed in the blog post "In the future, we plan to change the defaults so that only expect is available unless you explicitly enable should. We may do this as soon as RSpec 3.0, but we want to give users plenty of time to get acquainted with it."
I noticed that expect is now being used in many of the major gems that use rspec.
I changed the pattern matchers from =~ to match() or match_array() as required for this change and while at it I also took the opportunity to change the == format to eq as recommended in the post.
All previously passing tests still pass after this change.
I have tried to observe the existing style. The only exception is some blank spaces on empty lines - but I kept the empty lines themselves.