Conversation
- Bump required_ruby_version from >= 3.1.6 to >= 3.3 - Update TargetRubyVersion from 2.6 to 3.3 - Update RuboCop 1.65 -> 1.85 and rubocop-rspec 3.0 -> 3.9 - Migrate rubocop-rspec from require to plugins - Rename deprecated IgnoredPatterns to AllowedPatterns - Update all development dependencies and Bundler to latest - Add rake to Gemfile (no longer a default gem in newer Rubies) - Gitignore Ruby version manager tool files - Fix new cop offenses: Style/RedundantRegexpArgument, RSpec/BeEq, Style/HashSyntax, Layout/LineContinuationSpacing, Lint/RedundantCopDisableDirective Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Travis CI stopped free OSS builds in 2021. Add a GitHub Actions workflow that tests Ruby 3.3, 3.4, and 4.0 on every push to main and on all pull requests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the gem’s supported Ruby/tooling baseline and modernizes CI to keep development workflows current and maintainable.
Changes:
- Raise required Ruby version to >= 3.3 and reflect it in the gemspec and README.
- Upgrade RuboCop + rubocop-rspec and apply small code/spec adjustments to satisfy new cops.
- Replace Travis CI with a GitHub Actions workflow running the default rake task across a Ruby version matrix.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
cacheable.gemspec |
Bumps required Ruby version to >= 3.3. |
README.md |
Adds GitHub Actions CI badge and documents the Ruby requirement; fixes a small typo. |
.github/workflows/ci.yml |
Introduces GitHub Actions CI running bundle exec rake across multiple Ruby versions. |
.travis.yml |
Removes legacy Travis CI configuration. |
.rubocop.yml |
Updates RuboCop configuration for the newer RuboCop/plugin configuration style and Ruby target version. |
spec/.rubocop.yml |
Removes some spec-only RuboCop overrides now that offenses were addressed locally. |
Gemfile / Gemfile.lock |
Updates lint/dev dependencies (incl. RuboCop versions) and adds rake to support CI’s bundle exec rake. |
lib/cacheable/method_generator.rb |
Minor refactor/inline cop directive related to RuboCop updates. |
lib/cacheable/cache_adapters/memory_adapter.rb |
Adds an inline cop disable documenting why delete does not follow predicate naming. |
spec/cacheable/cacheable_spec.rb |
Adjusts specs for new RuboCop rules and to match the (target, method_name, args) proc calling convention. |
spec/cacheable/cache_adapters/memory_adapter_spec.rb |
Updates boolean expectations to be(true/false). |
.gitignore |
Ignores common Ruby/tool version files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@rofreg I'm getting more practice with AI and felt I could use it do a little open source housekeeping and improvement. Let me know if there's someone better I can tag on these. These aren't urgent either, just nice to keep up to date. |
rofreg
left a comment
rofreg
left a comment
There was a problem hiding this comment.
Eyy, love it! Me or Jess are probably still the right people 😁
Honestly, it might be nice to merge a few cleanup/modernization PRs, publish an update, then mark the project as officially unmaintained (at least by Splitwise). It's been pretty sturdy for a while, and that seems like that'd leave the gem in a reasonable place for anyone who wants to keep using it at this point!
Summary