Allow hijacking of getUserMedia() without videoIds#1
Open
zz85 wants to merge 2 commits intospite:masterfrom
Open
Allow hijacking of getUserMedia() without videoIds#1zz85 wants to merge 2 commits intospite:masterfrom
zz85 wants to merge 2 commits intospite:masterfrom
Conversation
Owner
|
I don't know how I feel about polluting the Window object. I also think that the original idea is to provide an extra Input source, nor to hijack actual sources. But i do like that the virtual webcam could "impersonate" a specific type of VideoInput. May be it's better suited for a different use case/extension? |
Author
|
Ah what you said make sense, that the virtual webcam is meant to be an additional input device. I agree that window object override is rather hackish. If you like to accept a toggle from the add-on, perhaps I could get it to pass from it as an option to the function. Another thing I realized, once the virtual webcam is turned on, the webcam lights stay on for the life time duration of the page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for example, some sites may call
without videoId. If
window.videoHijackis set to true, allow virtual-webcam to attempt hostile takeover