Skip to content

Allow hijacking of getUserMedia() without videoIds#1

Open
zz85 wants to merge 2 commits intospite:masterfrom
zz85:master
Open

Allow hijacking of getUserMedia() without videoIds#1
zz85 wants to merge 2 commits intospite:masterfrom
zz85:master

Conversation

@zz85
Copy link

@zz85 zz85 commented May 12, 2020

for example, some sites may call

getUserMedia({video:
  facingMode: "user"
  frameRate: 15
  height: 360
  width: 640
}

without videoId. If window.videoHijack is set to true, allow virtual-webcam to attempt hostile takeover

@spite
Copy link
Owner

spite commented May 14, 2020

I don't know how I feel about polluting the Window object. I also think that the original idea is to provide an extra Input source, nor to hijack actual sources. But i do like that the virtual webcam could "impersonate" a specific type of VideoInput. May be it's better suited for a different use case/extension?

@zz85
Copy link
Author

zz85 commented May 16, 2020

Ah what you said make sense, that the virtual webcam is meant to be an additional input device. I agree that window object override is rather hackish. If you like to accept a toggle from the add-on, perhaps I could get it to pass from it as an option to the function. Another thing I realized, once the virtual webcam is turned on, the webcam lights stay on for the life time duration of the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants