Open
Conversation
Because Html2Pdf loop through html elements, and creates a lot of sub elements, each time a sub element is cleared, a complete scan of /tmp/ dir was made to delete temp files. These modifs allow to make only ONE scan in /tmp/ dir, at the end of generation, to delete temp files.
k00ni
reviewed
Aug 5, 2020
| static protected $_tables = array(); // static table to prepare the nested html tables | ||
| static protected $_subobj = null; // object html2pdf prepared in order to accelerate the creation of sub html2pdf | ||
| static protected $_tables = array(); // static table to prepare the nested html tables | ||
| static protected $_tmpFilesAreCleaned = false; // flag : file cleaning is done |
There was a problem hiding this comment.
It seems there are some additional white spaces here.
Comment on lines
+112
to
+114
| * Get the private variable file_id, for cleaning tmp files | ||
| * @access public | ||
| */ |
There was a problem hiding this comment.
The * should be in line, but different amounts of white spaces are used for each line.
Closed
|
Can someone merge this please ? @k00ni |
|
I am sorry, I can't. Just wanted to help by making a review. |
|
ping @spipu ? I have a performance problem since I upgraded. Thx 👍 |
|
Friendly ping @spipu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because Html2Pdf loop through html elements, and creates a lot of sub elements, each time a sub element is cleared, a complete scan of /tmp/ dir was made to delete temp files.
These modifs allow to make only ONE scan in /tmp/ dir, at the end of generation, to delete temp files.