fix: preserve WriterTo and ReaderFrom in BasePathFile#577
Open
JY-Sun-K wants to merge 1 commit intospf13:masterfrom
Open
fix: preserve WriterTo and ReaderFrom in BasePathFile#577JY-Sun-K wants to merge 1 commit intospf13:masterfrom
JY-Sun-K wants to merge 1 commit intospf13:masterfrom
Conversation
|
|
JY-Sun-K
force-pushed
the
fix/basepath-writerto-readerfrom
branch
from
c7213cb to
d17dc02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #576
Issue #576
Summary
io.WriterToandio.ReaderFromonBasePathFileio.Copyfast-path behavior throughBasePathFsWhy
BasePathFswraps opened files inBasePathFile, which hides optional interfaces implemented by the underlying file. As a result,io.Copycan no longer observeio.WriterTo/io.ReaderFromand falls back to the generic copy loop.This restores those optional interfaces on the wrapper while keeping
afero.Fileunchanged and preserving the existingBasePathFspath-jail behavior.Test Plan
go test ./...