Open
Conversation
brathina-spectro
requested changes
Jun 13, 2023
brathina-spectro
requested changes
Sep 14, 2023
| # Declare variables to be passed into your templates. | ||
|
|
||
| charts: | ||
| applier: |
Collaborator
There was a problem hiding this comment.
Chart name should be stormforge-applier
| "charts/stormforge-applier-2.0.0-beta.9.tgz" | ||
| ], | ||
| "addonType": "monitoring", | ||
| "annotations": {} |
Collaborator
There was a problem hiding this comment.
These packs should have additional annotations to differentiate community vs spectrocloud managed.
| "charts/stormforge-agent-2.0.3.tgz" | ||
| ], | ||
| "addonType": "monitoring", | ||
| "annotations": {} |
Collaborator
There was a problem hiding this comment.
These packs should have additional annotations to differentiate community vs spectrocloud managed.
| @@ -0,0 +1,7 @@ | |||
| charts.stormforge-agent.authorization.clientID: | |||
| schema: '{{ required }}' | |||
Collaborator
There was a problem hiding this comment.
A hint will be useful in all these schema for novice users. Check doc on hints usage. Will give a tooltip in the UI for users to understand what these fields are.
Collaborator
|
@stenwt Apologies for the delay in getting this reviewed. Since there were no updates during the initial days after my last comment, i assumed we're not actively working on this pack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.