security(PS-1634): remove T-Mobile customer name references from work…#97
Open
brathina-spectro wants to merge 2 commits intomainfrom
Open
security(PS-1634): remove T-Mobile customer name references from work…#97brathina-spectro wants to merge 2 commits intomainfrom
brathina-spectro wants to merge 2 commits intomainfrom
Conversation
…ing tree Removes all hardcoded T-Mobile references from live configuration files as required by PS-1634 (bug bounty report - customer attribution exposure). Files remediated: - discovery/modules/tke-cluster/cluster.tf - discovery/config/namespace-labeler.yaml - discovery/config-stg/namespace-labeler.yaml - discovery-airgap/config/namespace-labeler.yaml - discovery-airgap/config-stg/namespace-labeler.yaml Git history purge (all branches) to follow as a separate step. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes hardcoded customer-identifying T‑Mobile label references from Terraform and namespace-labeler job configs to address PS-1634 (customer attribution exposure).
Changes:
- Removed commented/inline
k8s.t-mobile.com/*labels from the vSphere cluster module (Terraform). - Removed
k8s.t-mobile.com/*namespace labels from namespace-labeler Job manifests across live/staging and airgap variants.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| discovery/modules/tke-cluster/cluster.tf | Removes hardcoded k8s.t-mobile.com/* worker/master pool labels. |
| discovery/config/namespace-labeler.yaml | Removes k8s.t-mobile.com/* label entries from the namespace labeler. |
| discovery/config-stg/namespace-labeler.yaml | Same removal for staging. |
| discovery-airgap/config/namespace-labeler.yaml | Same removal for airgap. |
| discovery-airgap/config-stg/namespace-labeler.yaml | Same removal for airgap staging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…labeler jobs Addresses Copilot review feedback on PR #97. When labels_arr is empty (after removing customer-specific labels), the Job would still run as a privileged no-op with wildcard RBAC on namespaces. Adding an early-exit prevents unnecessary execution of the privileged components. Affected files: - discovery/config/namespace-labeler.yaml - discovery/config-stg/namespace-labeler.yaml - discovery-airgap/config/namespace-labeler.yaml - discovery-airgap/config-stg/namespace-labeler.yaml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing tree
Removes all hardcoded T-Mobile references from live configuration files as required by PS-1634 (bug bounty report - customer attribution exposure).
Files remediated:
Git history purge (all branches) to follow as a separate step.