Skip to content

Added comparison between read and unread in Compact and Super Compact modes.#352

Open
bannedbook wants to merge 1 commit intospacecowboy:masterfrom
bannedbook:master
Open

Added comparison between read and unread in Compact and Super Compact modes.#352
bannedbook wants to merge 1 commit intospacecowboy:masterfrom
bannedbook:master

Conversation

@bannedbook
Copy link
Copy Markdown

Added comparison between read and unread article titles in Compact and Super Compact modes.

In Compact and Super Compact modes, it is difficult to distinguish between read and unread articles. This PR will improve this problem.

Copy link
Copy Markdown
Owner

@spacecowboy spacecowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

Also by comparison you actually mean difference. And this change will affect all styles, not only compact/super compact.

Comment on lines +214 to +219
// The color of unread items remains unchanged, and the color of read items increases transparency
val titleColor = if (item.unread) {
Color.Unspecified // Use the default color and do not change the color of unread items
} else {
LocalContentColor.current.copy(alpha = 0.74f) //Increase transparency of read item color
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this should be moved inside the FeedListItemTitleTextStyle function in Typography.kt. See how the the font weight uses the unread flag:

fontWeight = titleFontWeight(item.unread)

@spacecowboy
Copy link
Copy Markdown
Owner

Also please run ./gradlew ktlintFormat on the code.

@bannedbook
Copy link
Copy Markdown
Author

Yes, yes, this change will affect all styles.
But before this, In Compact and Super Compact modes, it is difficult to distinguish between read and unread articles.
So, it mainly solves the problem of Compact and Super Compact, but it also affects other modes, but it does not destroy the effect, which should have a better effect , but the effect is just not obvious .

@Jiogo18 Jiogo18 mentioned this pull request Sep 14, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants