Added comparison between read and unread in Compact and Super Compact modes.#352
Added comparison between read and unread in Compact and Super Compact modes.#352bannedbook wants to merge 1 commit intospacecowboy:masterfrom
Conversation
…d Super Compact modes.
spacecowboy
left a comment
There was a problem hiding this comment.
See inline comment.
Also by comparison you actually mean difference. And this change will affect all styles, not only compact/super compact.
| // The color of unread items remains unchanged, and the color of read items increases transparency | ||
| val titleColor = if (item.unread) { | ||
| Color.Unspecified // Use the default color and do not change the color of unread items | ||
| } else { | ||
| LocalContentColor.current.copy(alpha = 0.74f) //Increase transparency of read item color | ||
| } |
There was a problem hiding this comment.
All of this should be moved inside the FeedListItemTitleTextStyle function in Typography.kt. See how the the font weight uses the unread flag:
fontWeight = titleFontWeight(item.unread)
|
Also please run |
|
Yes, yes, this change will affect all styles. |
Added comparison between read and unread article titles in Compact and Super Compact modes.
In Compact and Super Compact modes, it is difficult to distinguish between read and unread articles. This PR will improve this problem.