fix: replace @iarna/toml with smol-toml for TOML 1.0 and PEP 735 support#208
Open
TALLEC-Scott wants to merge 1 commit intosourcegraph:scipfrom
Open
fix: replace @iarna/toml with smol-toml for TOML 1.0 and PEP 735 support#208TALLEC-Scott wants to merge 1 commit intosourcegraph:scipfrom
TALLEC-Scott wants to merge 1 commit intosourcegraph:scipfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #207
Problem
@iarna/toml fails to parse mixed-type arrays (inline tables + strings) which is valid TOML 1.0 syntax used by PEP 735 dependency groups.
Error
[dependency-groups]
dev = [
{include-group = "test"}, # inline table
"ml_stack_document_extraction", # string
]
Results in:
TomlError: line 66, col 34
Config file "pyproject.toml" could not be parsed.
Solution
Replace @iarna/toml (unmaintained since 2019) with smol-toml - a modern, actively maintained TOML parser that correctly handles TOML 1.0 syntax.
Changes
Testing