Merged
Conversation
fredszaq
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this issue in #223 but felt it should go in it's own PR.
In rust-lang/cargo#13324, msrv was bumped to 1.73 (MSRV=N-2) and someplace down the line a patch release tocargo-platformwas published. CI is pulling incargo-platformfor0.1.8which has msrv of 1.73.Clap and clap_derive were bumped to msrv 1.74 clap-rs/clap#5343
There's an automated bot that updates the MSRV on cargo and cargo's subcrates so rust-lang/cargo#13577 will cause breakages in the future.
After having changed this from 1.73 to 1.74, I feel like there should be a way to automate this similar to rust-lang/cargo#13577. Though, I wish those bumps weren't considered patch releases :/