fix: Improved type checking for UnnecessaryLambdaEnclosingParameters#910
Open
gbq6 wants to merge 3 commits intosolven-eu:masterfrom
Open
fix: Improved type checking for UnnecessaryLambdaEnclosingParameters#910gbq6 wants to merge 3 commits intosolven-eu:masterfrom
gbq6 wants to merge 3 commits intosolven-eu:masterfrom
Conversation
blacelle
reviewed
Sep 28, 2025
| var newLambdaExpr = lambdaExpr.clone(); | ||
| newLambdaExpr.setEnclosingParameters(false); | ||
| return tryReplace(lambdaExpr, newLambdaExpr); | ||
| if (lambdaExpr.getParameters().size() != 1 || lambdaExpr.isExplicitlyTyped()) { |
Member
There was a problem hiding this comment.
Could you craft a unit-test catching what's brought by this PR?
Contributor
Author
There was a problem hiding this comment.
Actually any test with @CompareMethods would have revealed this issue, but as the the JavaParser seems to ignore setEnclosingParameters(false) these tests are ignored. I'll add a comment regarding that if you don't mind though.
Edit: 24f869e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.