Skip to content

fix(web): 홈 뉴스 섹션 이미지 CDN 래핑 누락 수정#474

Merged
manNomi merged 2 commits intomainfrom
codex/fix-home-news-cdn-wrap
Mar 14, 2026
Merged

fix(web): 홈 뉴스 섹션 이미지 CDN 래핑 누락 수정#474
manNomi merged 2 commits intomainfrom
codex/fix-home-news-cdn-wrap

Conversation

@manNomi
Copy link
Contributor

@manNomi manNomi commented Mar 14, 2026

변경 내용

  • 메인페이지 "솔커에서 맛보는 소식" 섹션의 뉴스 썸네일 이미지에 CDN URL 래핑이 누락되어 일부 이미지 로드가 실패하던 문제를 수정했습니다.
  • FallbackImagecdnHostType="upload"를 추가해 상대 경로 이미지가 업로드 CDN 기준으로 정상 변환되도록 적용했습니다.
  • 절대 URL(https://...) 이미지는 기존처럼 그대로 동작하므로 기존 동작에 영향이 없습니다.

수정 파일

  • apps/web/src/app/(home)/_ui/NewsSection/index.tsx

검증

  • pnpm --filter @solid-connect/web run lint:check
  • pnpm --filter @solid-connect/web run typecheck:ci
  • pre-push hook: ci:check + next build 통과

@vercel
Copy link

vercel bot commented Mar 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connection-web Ready Ready Preview, Comment Mar 14, 2026 10:18am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped Mar 14, 2026 10:18am

@github-actions github-actions bot added the web label Mar 14, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ad63eb24-fa3d-4771-b17a-38076bfc553b

📥 Commits

Reviewing files that changed from the base of the PR and between 3961a1d and a46b362.

📒 Files selected for processing (1)
  • apps/web/src/app/(home)/_ui/NewsSection/index.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/web/src/app/(home)/_ui/NewsSection/index.tsx

Walkthrough

  1.  Image 컴포넌트에 `cdnHostType="default"` 속성이 추가되었습니다.  
    
  2.  제어 흐름이나 에러 처리 로직에는 변경이 없으며 단순히 렌더링 시 전달되는 속성만 늘어났습니다.
    

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • wibaek
  • enunsnv
  • khwww
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive PR 설명에서 필수 섹션 중 '관련 이슈'가 누락되었으며, 작업 내용과 검증 항목은 충분히 기술되어 있습니다. 관련 이슈 번호를 '## 관련 이슈' 섹션에 추가하면 더욱 완전한 PR 설명이 될 것입니다.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목은 홈 뉴스 섹션 이미지의 CDN 래핑 문제 해결이라는 실제 변경 사항을 명확하게 요약하고 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/fix-home-news-cdn-wrap
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel vercel bot temporarily deployed to Preview – solid-connect-web-admin March 14, 2026 10:15 Inactive
@manNomi manNomi merged commit bf041a2 into main Mar 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant