List files from local cache when pending S3 upload#8
Open
List files from local cache when pending S3 upload#8
Conversation
davekempe
reviewed
Mar 27, 2026
Member
davekempe
left a comment
There was a problem hiding this comment.
Looks good overall — clean approach, solid test coverage. One minor suggestion:
mergeLocalFiles should skip the .meta directory when recursing for images content. Currently it would treat .meta/ as a vmid subdirectory if it existed inside a content dir. Low risk since .meta lives at the cache root, but worth guarding:
if content == "images" {
if entry.Name() == ".meta" {
continue
}
// Recurse into VM ID subdirectories for imagesCo-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
mergeLocalFiles now skips the .meta directory when recursing into subdirectories for images content |
davekempe
approved these changes
Mar 28, 2026
Member
davekempe
left a comment
There was a problem hiding this comment.
Looks good — .meta guard added, tests pass, clean approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #7: Terraform bpg/proxmox provider fails to read back files immediately after upload —
failed to read file from "s3-iso:snippets/cloud-config-ubuntu.yaml".Root cause: When PVE writes a file directly to the cache directory (e.g. via the Terraform provider), the file watcher needs 3+ seconds (debounce + stability check) before uploading to S3 and indexing metadata. The
/v1/listendpoint only queries S3, so the file is invisible until the watcher completes the upload. The provider tries to read the file back immediately and fails becauselist_volumes()doesn't include it.Fix: Modify
handleListininternal/api/api.goto scan the local cache directory after querying S3, merging any files that exist locally but aren't yet in S3 into the response. Also improved the S3-unreachable fallback path to return locally cached files instead of an empty list.