-
Notifications
You must be signed in to change notification settings - Fork 7
Feature/harvesting metadata from a provided repository url via cloning #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aidajafarbigloo
wants to merge
11
commits into
softwarepub:develop
Choose a base branch
from
Aidajafarbigloo:feature/harvesting-metadata-from-a-provided-repository-URL-via-cloning
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
50a7afd
Add token management functions for TOML config
Aidajafarbigloo d27c6d5
Implement repository cloning
Aidajafarbigloo 17c8b80
Add URL and token arguments for harvesting
Aidajafarbigloo 459845f
Implement repository cloning and token updates
Aidajafarbigloo a6e45d1
Integrate logging shutdown in clean command
Aidajafarbigloo e0a527e
Update copyright holder
Aidajafarbigloo 1f3b31f
Update copyright holder
Aidajafarbigloo e128e15
Add detailed docstrings for better clarity on functions
Aidajafarbigloo 52d995f
Add detailed docstrings for better clarity on functions
Aidajafarbigloo abca6b3
Add bulk repository test for HERMES metadata harvesting
Aidajafarbigloo c0c71d1
Create test_repositories.json with sample URLs
Aidajafarbigloo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aidajafarbigloo Is it necessary for your changes to include logging? If not, please remove it everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sferenz Thank you for the comments.
When using
hermes cleancommand on Windows, I face this error:Run subcommand cleanRemoving HERMES caches...An error occurred during execution of clean (Find details in './hermes.log')Error in the "hermes.log":
Original exception was: [WinError 32] The process cannot access the file because it is being used by another process: '.hermes\\audit.log'.This happens because Windows does not allow deletion of a file that is still open by the current process. The
audit.logfile inside.hermesis held open by a logging file handler. Whenshutil.rmtree()attempts to remove the directory, it fails due to the open file handle. I'm usinglogging.shutdown()to ensure that all logging handlers are closed before the directory is deleted, it does not introduce new logging behavior.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was fixed before but somehow the fix got lost... Weird 🤔
#226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, not only once. But it seems more important to not have a log file in the working directory than having a properly cleaned .hermes cache.
you should be able to configure the path to the logfile, though.