Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for live-previewing color attributes (e.g., fill, stroke) in module previews by linking form color inputs to preview elements via generated data-attributes.
Changes:
- Added a
link_color_attributeTwig macro and a new admin preview JS feature to propagate color input values into preview element attributes. - Extended
sfs_cms_form_view_set_attr/_update_link_valueto optionally support multiple linked targets per input (comma-separated values). - Added a
show_toggleroption toColorTypeand updated thecms_color_widgettheme to optionally render without the enable/disable checkbox; hardenedcolor-type.jsnull checks.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/macros/modules_edit.html.twig | Adds link_color_attribute macro and extends _update_link_value for multi-target linking. |
| templates/forms/types_theme.html.twig | Makes the color “toggler” UI optional based on show_toggler. |
| src/Twig/Extension/EditFormExtension.php | Updates formViewSetAttr to support appending multiple unique values. |
| src/Form/Type/ColorType.php | Introduces show_toggler option and exposes it to Twig via buildView. |
| assets/scripts/types/color-type.js | Adds guards to avoid errors when expected DOM wrappers aren’t present. |
| assets/scripts/admin/content-edit/preview-color-attribute.js | New feature: updates preview element attributes from linked color inputs. |
| assets/scripts/admin-cms.js | Registers the new preview feature in the admin bundle entrypoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
evabelpeq
previously approved these changes
Mar 27, 2026
javihgil
added a commit
that referenced
this pull request
Mar 27, 2026
* Support preview color to custom attributes * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix code style --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.