Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for toggling preview elements based on the selected value of choice fields (currently implemented for <select> elements) in the admin content editor.
Changes:
- Added a Twig macro to link preview elements to a “choice toggle” controller and specify which choice values should show the target.
- Extended the admin preview toggle JS to listen to choice changes and show/hide preview targets based on configured value lists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| templates/macros/modules_edit.html.twig | Adds link_choice_toggle macro to generate data-attributes for choice-based preview toggling. |
| assets/scripts/admin/content-edit/preview-toggle.js | Implements choice-based toggling logic and initializes toggles on page load. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
evabelpeq
requested changes
Mar 27, 2026
javihgil
added a commit
that referenced
this pull request
Mar 27, 2026
* Support toggle preview for choices * Support toggle preview for choices * Fix preview-toggle.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.