Migrate data import/export to new cms-data-plugin#450
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the CMS bundle’s legacy import/export + fixtures implementation and switches the default admin import configuration to use the new cms-data-plugin templates and form types.
Changes:
- Remove legacy Twig templates, Symfony form types, action listeners, commands, and data import/export classes (previously marked deprecated).
- Remove Doctrine fixtures purger/factory and bundled fixtures loader.
- Update content admin config defaults to reference
@SfsCmsDataPlugin/...views andSoftspring\CmsDataPlugin\...form types.
Reviewed changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/admin/content/version_import.html.twig | Removed legacy version import admin template (now expected in cms-data-plugin). |
| templates/admin/content/import_version.html.twig | Removed deprecated alias template for version import. |
| templates/admin/content/import.html.twig | Removed legacy content import admin template (now expected in cms-data-plugin). |
| src/Form/Admin/ContentVersion/VersionImportFormInterface.php | Removed legacy version import form interface. |
| src/Form/Admin/ContentVersion/VersionImportForm.php | Removed legacy version import Symfony form type. |
| src/Form/Admin/Content/ContentImportFormInterface.php | Removed legacy content import form interface. |
| src/Form/Admin/Content/ContentImportForm.php | Removed legacy content import Symfony form type. |
| src/DependencyInjection/SfsCmsExtension.php | Dropped autoconfiguration for deprecated data transformer tags. |
| src/DataFixtures/Purger/CmsPurgerFactory.php | Removed custom fixtures purger factory. |
| src/DataFixtures/Purger/CmsPurger.php | Removed custom fixtures purger implementation. |
| src/DataFixtures/CmsFixtures.php | Removed bundled fixtures loader fixture class. |
| src/Data/ReferencesRepository.php | Removed deprecated import/export reference repository. |
| src/Data/FieldTransformer/TranslationFieldTransformer.php | Removed deprecated field transformer. |
| src/Data/FieldTransformer/SiteFieldTransformer.php | Removed deprecated field transformer. |
| src/Data/FieldTransformer/RouteFieldTransformer.php | Removed deprecated field transformer. |
| src/Data/FieldTransformer/MediaFieldTransformer.php | Removed deprecated field transformer. |
| src/Data/FieldTransformer/FieldTransformerInterface.php | Removed deprecated transformer interface. |
| src/Data/FieldTransformer/EntityFieldTransformer.php | Removed deprecated field transformer. |
| src/Data/FieldTransformer/DefaultTransformer.php | Removed deprecated default transformer. |
| src/Data/FieldTransformer/BlockFieldTransformer.php | Removed deprecated field transformer. |
| src/Data/FieldTransformer/ArrayFieldTransformer.php | Removed deprecated field transformer. |
| src/Data/Exception/RunPreloadBeforeImportException.php | Removed deprecated import/export exception. |
| src/Data/Exception/ReferenceNotFoundException.php | Removed deprecated import/export exception. |
| src/Data/Exception/InvalidElementException.php | Removed deprecated import/export exception. |
| src/Data/Exception/DataTransformerNotFoundException.php | Removed deprecated import/export exception. |
| src/Data/EntityTransformer/RouteEntityTransformer.php | Removed deprecated entity transformer. |
| src/Data/EntityTransformer/PageEntityTransformer.php | Removed deprecated entity transformer. |
| src/Data/EntityTransformer/MenuEntityTransformer.php | Removed deprecated entity transformer. |
| src/Data/EntityTransformer/MediaEntityTransformer.php | Removed deprecated entity transformer. |
| src/Data/EntityTransformer/EntityTransformerInterface.php | Removed deprecated transformer interface. |
| src/Data/EntityTransformer/ContentEntityTransformerInterface.php | Removed deprecated transformer interface. |
| src/Data/EntityTransformer/ContentEntityTransformer.php | Removed deprecated content transformer base. |
| src/Data/EntityTransformer/BlockEntityTransformer.php | Removed deprecated entity transformer. |
| src/Data/DataTransformer.php | Removed deprecated data transformer orchestrator. |
| src/Data/DataImporter.php | Removed deprecated data importer. |
| src/Data/DataExporter.php | Removed deprecated data exporter. |
| src/Data/AbstractDataImportExport.php | Removed deprecated import/export base class. |
| src/Config/Model/Content.php | Updated default admin import config to cms-data-plugin view/type strings. |
| src/Command/DumpFixturesCommand.php | Removed command that dumped fixtures using legacy exporter. |
| src/Admin/ActionListener/ContentVersion/ImportListener.php | Removed legacy version import action listener. |
| src/Admin/ActionListener/ContentVersion/ExportListener.php | Removed legacy version export action listener. |
| src/Admin/ActionListener/Content/ImportListener.php | Removed legacy content import action listener. |
| config/services/services.yaml | Removed service wiring for legacy data/fixtures components and related binds. |
| config/services/controller/admin_content.yaml | No functional change (formatting-only line update). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AritzPalaciosOrtiz
previously approved these changes
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 59 out of 59 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (2)
cms/contents/page/translations/sfs_cms_contents.en.yaml:119
- The
versions.origintranslations for origin values2(fixture) and3(imported) were removed, butSoftspring\CmsBundle\Model\VersionInterfacestill definesORIGIN_FIXTURE = 2andORIGIN_IMPORT = 3, and the admin templates renderadmin_<type>.versions.origin.<origin>unconditionally. This will cause missing-translation output for existing content versions created in previous installs. Consider keeping these translations for backward compatibility even if the import/fixtures features are moved to a plugin.
origin:
"null": ""
1: "edited"
4: "translated"
5: "seo"
6: "duplicated"
7: "language added"
8: "site added"
cms/contents/page/translations/sfs_cms_contents.es.yaml:119
- The
versions.origintranslations for origin values2(fixture) and3(imported) were removed, butSoftspring\CmsBundle\Model\VersionInterfacestill definesORIGIN_FIXTURE = 2andORIGIN_IMPORT = 3, and the admin templates renderadmin_<type>.versions.origin.<origin>unconditionally. This will cause missing-translation output for existing content versions created in previous installs. Consider keeping these translations for backward compatibility even if the import/fixtures features are moved to a plugin.
origin:
"null": ""
1: "editado"
4: "traducida"
5: "seo"
6: "duplicada"
7: "idioma añadido"
8: "sitio añadido"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
javihgil
deleted the
migrate-import-export-features-to-new-cms-data-plugin
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.