Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the codebase for Symfony 8 compatibility, removing deprecated components and improving type safety. The changes include migrating from SensioFrameworkExtraBundle's ParamConverter to Symfony's ValueResolver, updating permission naming conventions, and applying modern PHP 8.4 type declarations.
Changes:
- Removed deprecated SensioFrameworkExtraBundle dependencies and ParamConverter implementations
- Updated permission constants from
ROLE_*toPERMISSION_SFS_ACCOUNT_*prefix - Added return type declarations to anonymous functions and methods throughout the codebase
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| templates/admin/accounts/details.html.twig | Updated permission constants to new naming convention |
| src/Security/Voter/DeprecatedPermissionVoter.php | Removed deprecated voter class |
| src/Request/ParamConverter/ContentParamConverter.php | Removed deprecated ParamConverter implementation |
| src/Security/Authorization/Voter/AccountAccessVoter.php | Added return type hints and simplified conditional logic |
| src/Form/Admin/*.php | Added return type declarations to choice_label closures |
| src/EventListener/*.php | Improved type checking with instanceof and added return types |
| src/Entity/*.php | Added return type declarations to map/filter closures and removed redundant constructor |
| src/Controller/*.php | Enhanced response type checking with instanceof |
| rector.php | Updated Rector configuration for PHP 8.4 and Symfony 8 |
| composer.json | Updated PHP requirement to 8.4 and Symfony dependencies to 8.0 |
| config/services/*.yaml | Updated permission constants in service configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.