Make argname normalization robust and exit 1 if invalid arg#18
Open
randallpittman wants to merge 2 commits intosofarocean:mainfrom
Open
Make argname normalization robust and exit 1 if invalid arg#18randallpittman wants to merge 2 commits intosofarocean:mainfrom
randallpittman wants to merge 2 commits intosofarocean:mainfrom
Conversation
tcj
approved these changes
Nov 3, 2023
tcj
approved these changes
Nov 3, 2023
Contributor
|
Thanks @randallpittman ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code doesn't handle passing
outpathnor some other args at the command line and the code for normalizing capitalization is brittle. This PR makes these both programmatic. Also, it exits with exitcode 1 (error) if the argname is invalid.