Merged
Conversation
Build Completed Successfully! 🎉Version: 1.10.2-ee975e0 Download Build |
Coverage Report
|
Collaborator
Author
|
Confirmed working during debug session with server owner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues with 1.19.4 not having a few functions
Copilot Summary
This pull request updates how item and enchantment names are handled and displayed, improving compatibility across different Minecraft versions and ensuring proper translation support. The changes introduce new utility methods for enchantment translation, refactor legacy text component conversion, and enhance version checks for translation features.
Compatibility and Translation Improvements
isTranslationSupported()toMCVersion.javafor centralized version checks to determine if translation keys are supported.ItemNameUtil.javato use translation keys when available, and provided a legacy fallback for older Minecraft versions.Enchantment Name Handling
getEnchantmentTranslatable()andgetEnchantmentName()inItemNameUtil.javato support both modern and legacy enchantment name display, ensuring correct naming across versions.UtilMethods.getEnchantmentsComponent()to use the new enchantment translation method for displaying enchantments in item tooltips.Text Component Conversion Refactor
TextComponent.fromLegacy()with a new utility methodShopMessage.componentFromLegacy()to handle differences between Minecraft versions, preventing errors on older versions.ShopMessage.javato use the newcomponentFromLegacy()method for consistent behavior [1] [2] [3].Minor Code Cleanup
ItemNameUtil.javafor better maintainability.getNameTranslatable()inItemNameUtil.javato be static for easier access and consistency.These changes collectively improve the reliability and user experience of item and enchantment name display, especially in environments with varying Minecraft versions.