Skip to content

Ensure that the release command is called with the prod milestone#102

Open
geoand wants to merge 1 commit intomasterfrom
release-prod-milestone
Open

Ensure that the release command is called with the prod milestone#102
geoand wants to merge 1 commit intomasterfrom
release-prod-milestone

Conversation

@geoand
Copy link
Copy Markdown
Member

@geoand geoand commented Aug 7, 2018

This is now needed since the release command is used to create releases
for each prod release (since the redhat branch is no longer being used)

This is now needed since the release command is used to create releases
for each prod release (since the redhat branch is no longer being used)
@geoand geoand requested a review from metacosm August 7, 2018 08:51
@metacosm
Copy link
Copy Markdown
Member

metacosm commented Aug 7, 2018

@geoand you should take a look at the automate-release branch, I've done something similar there, iirc…

@geoand
Copy link
Copy Markdown
Member Author

geoand commented Aug 7, 2018

I'll check it out, thanks

@geoand
Copy link
Copy Markdown
Member Author

geoand commented Aug 7, 2018

Indeed there is something similar, but it doesn't take the prod milestone into account. I will leave this open so we can compare and decide what to do when you get back :)

Copy link
Copy Markdown
Member

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About time I reviewed this! No idea how relevant that still is but might as well approve and merge! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants