zipper,node: reduce wrapper churn and grow key scratch geometrically#823
Closed
snissn wants to merge 1 commit intopr/appendonly-direct-borrow-gatefrom
Closed
zipper,node: reduce wrapper churn and grow key scratch geometrically#823snissn wants to merge 1 commit intopr/appendonly-direct-borrow-gatefrom
snissn wants to merge 1 commit intopr/appendonly-direct-borrow-gatefrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces allocation overhead in the zipper hot path by returning node.Node values instead of *node.Node pointers from loadNode, and grows the key scratch buffer geometrically to avoid per-step reallocations.
Changes:
loadNodenow returnsnode.Node(value) usingNewNodeView, avoiding per-load heap allocations; callers take&when passing to functions expecting*node.NodeensureKeyScratchgrows geometrically (doubling from min 64) instead of exact-fit allocation- Added unit test for geometric scratch reuse behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TreeDB/zipper/zipper.go | loadNode returns value node.Node via NewNodeView; callers use & for pointer params |
| TreeDB/node/leaf.go | Geometric growth for keyScratch buffer |
| TreeDB/node/key_scratch_test.go | New test verifying scratch reuse and growth |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Owner
Author
|
Closing in favor of standalone PR #825 (same core changes without stacked experimental dependencies).} |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing