Open
Conversation
…l problem with the double-free of the (Completion)packet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear maintainers of smol/polling,
this pull request fixes the issues of the branch master...notgull/completion-block.
I have "rebased" is against the current version of smol/polling.
IMHO the two issues are:
.) The IO_STATUS_BLOCK struct is smaller than the OVERLAPPED struct, that is sometimes(?) used as an IO_STATUS_BLOCK struct. I used a union of both structs instead of just the IO_STATUS_BLOCK.
.) The as_ptr method of the CompletionPacket never incremented the reference count of the Arc<> in the Packet and thus the memory pointed to in the Arc<> struct would thus be dropped in Poller::wait_deadline while the Arc<> in the CompletionPacket would still exist. This results in a double-free. I replaced the as_ptr method of the CompletionBlock with a new method.
I added a method to read the number of transferred bytes from the OVERLAPPED structure.
All tests succeed.
I am an experienced programmer, but pretty new to Rust, so the code in this pull request might not be optimal. I apologise.
Best,
Stephan