feat: add support for update report definition endpoint#125
Open
smcgowan-smartsheet wants to merge 18 commits intosmartsheet:reports-v1from
Open
feat: add support for update report definition endpoint#125smcgowan-smartsheet wants to merge 18 commits intosmartsheet:reports-v1from
smcgowan-smartsheet wants to merge 18 commits intosmartsheet:reports-v1from
Conversation
Contributor
Latest commit reformats documentation for improved readability. No new issues found.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
update docs-source with the new models, and enums
![roomote-v0[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Fix alphabetical ordering in smartsheet_enums.rst
Contributor
Review completed. The implementation looks solid and follows established SDK patterns. All models properly implement serialization, use appropriate type hints, and include comprehensive tests. The CHANGELOG has been updated appropriately. The previous alphabetical ordering issue in
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
remove invalid options
add update filters query param support
fix linting issue
change for consistency
change aggregationCriteria to summarizingCriteria to match spec
changed to PUT from PATCH no longer returning changed definition no longer needs query param
update objects based on latest spec
…ate-report-definition # Conflicts: # CHANGELOG.md # docs-source/smartsheet_enums.rst # docs-source/smartsheet_models.rst # smartsheet/models/__init__.py # smartsheet/models/enums/__init__.py # smartsheet/reports.py
fix merge issues
Contributor
Fixed the reported issues. All local checks passed. |
ggoranov-smar
requested changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adding support for update report definition endpoint
Type of Change
What Changes Were Made
update_report_definition()method in Reports class to update report definitionsReportDefinitionmodel with support for filters, grouping, aggregation, and sorting criteriaReportFilterExpressionmodel with recursive structure for complex filter logicReportFilterCriterionmodel for individual filter conditionsReportColumnIdentifiermodel for identifying columns in report criteriaReportGroupingCriterionmodel for report grouping configurationReportAggregationCriterionmodel for report aggregation configurationReportSortingCriterionmodel for report sorting configurationReportAggregationTypeenum (SUM, AVG, MIN, MAX, COUNT, FIRST, LAST)ReportBooleanOperatorenum (AND, OR) for filter expressionsReportFilterOperatorenum with 36 operators for filter criteriaReportSystemColumnTypeenum with report-specific system columns including SHEET_NAMEChecklist
docs-source/(see Documentation guidelines)