feat: add support for update report definition endpoint#157
Open
smcgowan-smartsheet wants to merge 13 commits intosmartsheet:reports-v1from
Open
feat: add support for update report definition endpoint#157smcgowan-smartsheet wants to merge 13 commits intosmartsheet:reports-v1from
smcgowan-smartsheet wants to merge 13 commits intosmartsheet:reports-v1from
Conversation
Reviewed latest changes. Test name updated to match implementation. No new issues found.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Review complete. Found 2 minor issues related to formatting and naming conventions.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote-v0[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
remove invalid options
add update filters query param support
fix prettier linting issue
change aggregationCriteria to summarizingCriteria to match spec add returns report definition
changed to PUT from PATCH no longer returning changed definition no longer needs query param
update objects based on latest spec
# Conflicts: # CHANGELOG.md # lib/reports/index.ts # lib/reports/types.ts # test/functional/client.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for PATCH /reports/{reportId}/definition endpoint