Skip to content

fix: fail to build usr#103

Merged
AndreCostaaa merged 21 commits intomainfrom
fix-fail-to-build-usr
Feb 3, 2025
Merged

fix: fail to build usr#103
AndreCostaaa merged 21 commits intomainfrom
fix-fail-to-build-usr

Conversation

@AndreCostaaa
Copy link
Contributor

@AndreCostaaa AndreCostaaa commented Feb 1, 2025

Fixes #102

  • There were some unused variables, returns on void function, missing returns on non-void function that are now fixed

  • Changed the CMakelists found in usr so we can pass some CFLAGS from the command line and modified the CI to pass -Werror when building

  • Refactored the old build-virt32 and build-virt64 by using a matrix making it easier to add new so3 configs to the CI

Also i've noticed that building usr in release mode fails in both arm and aarch64 toolchains. Not really sure it's something worth fixing for now at least so i'm not adding that option to the CI

@AndreCostaaa AndreCostaaa linked an issue Feb 1, 2025 that may be closed by this pull request
Copy link
Contributor

@daniel-rossier daniel-rossier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing, normally creating the branch from the issue should prefix with the number of issue. It seems the branch "fix-fail-to-build-usr" doesn't have such a prefix.

@AndreCostaaa AndreCostaaa merged commit bbb5ecc into main Feb 3, 2025
6 checks passed
@AndreCostaaa
Copy link
Contributor Author

Just one thing, normally creating the branch from the issue should prefix with the number of issue. It seems the branch "fix-fail-to-build-usr" doesn't have such a prefix.

Yes, i'm used to removing the number as i feel it doesn't really add much having it on the branch name

Just a personal opinion of course, will make sure to leave it for my next contributions here 😄

@AndreCostaaa AndreCostaaa deleted the fix-fail-to-build-usr branch February 3, 2025 19:44
@daniel-rossier
Copy link
Contributor

I guess it's really easy to mention a specific branch by its number rather than its title that nobody really remembers most of time. So it helps :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: fail to build usr

2 participants