Merged
Conversation
Closed
daniel-rossier
approved these changes
Feb 3, 2025
daniel-rossier
approved these changes
Feb 3, 2025
daniel-rossier
approved these changes
Feb 3, 2025
Contributor
daniel-rossier
left a comment
There was a problem hiding this comment.
Just one thing, normally creating the branch from the issue should prefix with the number of issue. It seems the branch "fix-fail-to-build-usr" doesn't have such a prefix.
daniel-rossier
approved these changes
Feb 3, 2025
daniel-rossier
approved these changes
Feb 3, 2025
daniel-rossier
approved these changes
Feb 3, 2025
daniel-rossier
approved these changes
Feb 3, 2025
daniel-rossier
approved these changes
Feb 3, 2025
daniel-rossier
approved these changes
Feb 3, 2025
daniel-rossier
approved these changes
Feb 3, 2025
daniel-rossier
approved these changes
Feb 3, 2025
daniel-rossier
approved these changes
Feb 3, 2025
daniel-rossier
approved these changes
Feb 3, 2025
daniel-rossier
approved these changes
Feb 3, 2025
Contributor
Author
Yes, i'm used to removing the number as i feel it doesn't really add much having it on the branch name Just a personal opinion of course, will make sure to leave it for my next contributions here 😄 |
Contributor
|
I guess it's really easy to mention a specific branch by its number rather than its title that nobody really remembers most of time. So it helps :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102
There were some unused variables, returns on void function, missing returns on non-void function that are now fixed
Changed the CMakelists found in
usrso we can pass some CFLAGS from the command line and modified the CI to pass-Werrorwhen buildingRefactored the old
build-virt32andbuild-virt64by using a matrix making it easier to add new so3 configs to the CIAlso i've noticed that building
usrin release mode fails in botharmandaarch64toolchains. Not really sure it's something worth fixing for now at least so i'm not adding that option to the CI