Add the ability to specify min notification interval#356
Open
enthrops wants to merge 3 commits intosmartinez87:masterfrom
enthrops:throttling
Open
Add the ability to specify min notification interval#356enthrops wants to merge 3 commits intosmartinez87:masterfrom enthrops:throttling
enthrops wants to merge 3 commits intosmartinez87:masterfrom
enthrops:throttling
Conversation
This reverts commit 15d2c24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #224, but with customizable notification interval and using Rails cache instead of an ivar, which is not safe for multiprocess setups. Sorry for no tests, but after spending so much time with rspec, I can't for the life of me understand how to test complicated logic with minitest. Maybe someone else can add them. Thanks!